From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 71EC72C088 for ; Thu, 11 Apr 2019 09:00:16 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qZl2fqrhlCLc for ; Thu, 11 Apr 2019 09:00:16 -0400 (EDT) Received: from smtp57.i.mail.ru (smtp57.i.mail.ru [217.69.128.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 1BCB32C087 for ; Thu, 11 Apr 2019 09:00:15 -0400 (EDT) Received: by smtp57.i.mail.ru with esmtpa (envelope-from ) id 1hEZJO-0005wr-6k for tarantool-patches@freelists.org; Thu, 11 Apr 2019 16:00:14 +0300 Date: Thu, 11 Apr 2019 16:00:14 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH 2/2] swim: expose ping broadcast API Message-ID: <20190411130014.GB2123@chai> References: <8a92b8b538213827ac0ae156263bc88974e320c3.1554918303.git.v.shpilevoy@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8a92b8b538213827ac0ae156263bc88974e320c3.1554918303.git.v.shpilevoy@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org * Vladislav Shpilevoy [19/04/10 21:01]: > +/** > + * Broadcast a ping to all interfaces on a specified @a port. If > + * @a port is < 0, then a port of the SWIM instance is used. > + */ Please add to the comment information about possible errors - memory allocation error or there are no interfaces available for broadcast. Mention what errors are not detected since the broadcast itself happens asynchronously - errors related to writing to network, these are simply ignored. > +int > +swim_broadcast(struct swim *swim, int port); -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov