From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id E671C2B73D for ; Thu, 11 Apr 2019 02:36:46 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ue2kvpB5Qmii for ; Thu, 11 Apr 2019 02:36:46 -0400 (EDT) Received: from smtp33.i.mail.ru (smtp33.i.mail.ru [94.100.177.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 258A32B724 for ; Thu, 11 Apr 2019 02:36:46 -0400 (EDT) Date: Thu, 11 Apr 2019 09:36:43 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH v1 3/3] sql: remove unused functions from main.c Message-ID: <20190411063643.GP8268@chai> References: <61b31e4086c3914a3b76683e531e1309a70cd291.1554830037.git.imeevma@gmail.com> <20190410073147.GJ8268@chai> <74B61010-2EA1-4743-A9DE-F6F39F6265E2@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <74B61010-2EA1-4743-A9DE-F6F39F6265E2@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: Imeev Mergen * n.pettik [19/04/11 08:09]: OK, agree on both points. > > * imeevma@tarantool.org [19/04/09 20:19]: > >> -int > >> -sql_shutdown(void) > > > > This could be actually useful when debugging memory leaks, Nikita, > > what's your take? > > I believe it is broken and useless. What is more, we are going > to completely remove SQLite's original allocators and use only > malloc and region. So, it makes no sense to leave this function. > If we may need to have smth like that someday, it will be easier > to implement it from scratch (IMHO). > > >> -/* > >> - * Cause any pending operation to stop at its earliest opportunity. > >> - */ > >> -void > >> -sql_interrupt(sql * db) > >> -{ > >> - db->u1.isInterrupted = 1; > >> -} > > > > This could also be useful. > > TBO I don’t understand why it could be useful and how it can > be applied to our SQL implementation at all. Furthermore, > there’s no guarantee that we haven’t removed some parts > of this functionality during previous refactorings. Let’s finish it. > -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov