From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id D64F92A36E for ; Wed, 10 Apr 2019 03:31:49 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id As1l3nWe-Ig1 for ; Wed, 10 Apr 2019 03:31:49 -0400 (EDT) Received: from smtp33.i.mail.ru (smtp33.i.mail.ru [94.100.177.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 85A2C1FE5F for ; Wed, 10 Apr 2019 03:31:49 -0400 (EDT) Date: Wed, 10 Apr 2019 10:31:47 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH v1 3/3] sql: remove unused functions from main.c Message-ID: <20190410073147.GJ8268@chai> References: <61b31e4086c3914a3b76683e531e1309a70cd291.1554830037.git.imeevma@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <61b31e4086c3914a3b76683e531e1309a70cd291.1554830037.git.imeevma@gmail.com> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: korablev@tarantool.org * imeevma@tarantool.org [19/04/09 20:19]: > -int > -sql_shutdown(void) This could be actually useful when debugging memory leaks, Nikita, what's your take? > -/* > - * This API allows applications to modify the global configuration of > - * the sql library at run-time. > - * > - * This routine should only be called when there are no outstanding > - * database connections or memory allocations. This routine is not > - * threadsafe. Failure to heed these warnings can lead to unpredictable > - * behavior. > - */ > -int > -sql_config(int op, ...) > -{ This is OK to remove. > -/* > - * Cause any pending operation to stop at its earliest opportunity. > - */ > -void > -sql_interrupt(sql * db) > -{ > - db->u1.isInterrupted = 1; > -} This could also be useful. The rest of the patch is looking good to me. Let's wait for Nikita's review. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov