From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 816462AF27
	for <tarantool-patches@freelists.org>; Sun,  7 Apr 2019 03:29:07 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id mh5VH1BWVjR2 for <tarantool-patches@freelists.org>;
	Sun,  7 Apr 2019 03:29:07 -0400 (EDT)
Received: from smtp1.mail.ru (smtp1.mail.ru [94.100.179.111])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 2E3192AE3C
	for <tarantool-patches@freelists.org>; Sun,  7 Apr 2019 03:29:07 -0400 (EDT)
Date: Sun, 7 Apr 2019 10:28:59 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v1] test: use unix sockets iproto
Message-ID: <20190407072859.rit3bxatkvgn5rfq@tkn_work_nb>
References: <94c6bd7f591a74c519e919612f3091577f8bcca6.1554367686.git.avtikhon@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <94c6bd7f591a74c519e919612f3091577f8bcca6.1554367686.git.avtikhon@tarantool.org>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-Help: <mailto:ecartis@freelists.org?Subject=help>
List-Unsubscribe: <mailto:tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-Subscribe: <mailto:tarantool-patches-request@freelists.org?Subject=subscribe>
List-Owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-Archive: <http://www.freelists.org/archives/tarantool-patches>
To: avtikhon <avtikhon@tarantool.org>
Cc: tarantool-patches@freelists.org

Hi!

Please, do self-review before send a patch. I'm sure you would ask the
same questions that I asked below and either fix them or describe
reasons in the commit message.

WBR, Alexander Turenko.

On Thu, Apr 04, 2019 at 11:49:50AM +0300, avtikhon wrote:
> Set to use unix sockets iproto instead of TCP sockets.

A reason? Yep, I know, it is avoiding 'Address already in use' errors.
And I know that it is because port checking in test-run is not
sufficient and races are possible. But a reader of your commit unlikely
have enough context.

It worth to add a link to related test-run issue here.

And don't forget to add fixes / closes #xxxx and the end of a commit
message.

> ---
> 
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4008-test-in-parallel-iproto
> Issue: https://github.com/tarantool/tarantool/issues/4008

> diff --git a/test/vinyl/replica_rejoin.lua b/test/vinyl/replica_rejoin.lua
> index 7cb7e09a4..9b95d50aa 100644
> --- a/test/vinyl/replica_rejoin.lua
> +++ b/test/vinyl/replica_rejoin.lua
> @@ -7,7 +7,7 @@ end
>  
>  box.cfg({
>      replication     = replication,
> -    vinyl_memory    = 1024 * 1024,
> +    vinyl_memory    = 107374182,
>  })

How it related to the patch?

>  require('console').listen(os.getenv('ADMIN'))
> diff --git a/test/vinyl/replica_rejoin.result b/test/vinyl/replica_rejoin.result
> index 1dfcb91b8..f590e05b2 100644
> --- a/test/vinyl/replica_rejoin.result
> +++ b/test/vinyl/replica_rejoin.result
> @@ -51,8 +51,6 @@ fio.glob(fio.pathjoin(box.space.test.id, 0, '*'))
>  ---
>  - - 9000/0/00000000000000000002.index
>    - 9000/0/00000000000000000002.run
> -  - 9000/0/00000000000000000004.index
> -  - 9000/0/00000000000000000004.run

And this.