From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 7FDE92BF93 for ; Fri, 5 Apr 2019 11:35:57 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id i2X7g5r3kM0Q for ; Fri, 5 Apr 2019 11:35:57 -0400 (EDT) Received: from smtp37.i.mail.ru (smtp37.i.mail.ru [94.100.177.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 2095A2ACC3 for ; Fri, 5 Apr 2019 11:35:57 -0400 (EDT) Date: Fri, 5 Apr 2019 18:35:54 +0300 From: Kirill Yukhin Subject: [tarantool-patches] Re: [PATCH] sql: fix extra type calculation before bytecode generation Message-ID: <20190405153554.qmqrjlfj4phu3qeh@tarantool.org> References: <20190405000627.58693-1-korablev@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190405000627.58693-1-korablev@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: v.shpilevoy@tarantool.org, Nikita Pettik Hello, On 05 Apr 03:06, Nikita Pettik wrote: > In SQL type of constant literal (e.g. 1, 2.5, 'abc') is assigned right > after parsing and saving into struct Expr. Occasionally, type is > re-assigned before emitting opcodes to store literal into VDBE memory. > What is more, for floating point number type is changed to "integer". > This patch fixes this obvious misbehaviour. > --- > Branch: https://github.com/tarantool/tarantool/tree/np/fix-float-type-meta I've checked the patch into master and 2.1 branch. -- Regards, Kirill Yukhin