From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 0029F2C004 for ; Fri, 5 Apr 2019 02:18:51 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0aaD82HKLg5J for ; Fri, 5 Apr 2019 02:18:50 -0400 (EDT) Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id ACBF42B853 for ; Fri, 5 Apr 2019 02:18:50 -0400 (EDT) Date: Fri, 5 Apr 2019 09:18:46 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH v2] xrow: print corrupted rows on decoding error. Message-ID: <20190405061846.GA24274@chai> References: <20190401130906.31356-1-sergepetrenko@tarantool.org> <20190403091827.qh5rxxpsbrkl35bp@esperanza> <338F2586-287A-4521-A6EE-F9E738FF6701@tarantool.org> <20190404120637.x7s5bulkubcaqweh@esperanza> <20190404145110.7mqil2sf6pmcfkn4@esperanza> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190404145110.7mqil2sf6pmcfkn4@esperanza> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: Serge Petrenko , Kirill Yukhin * Vladimir Davydov [19/04/04 17:57]: > Pushed to master, 2.1, 1.10. This was fast. First of all, we already have request_str() function, and there is a good deal of code reuse that can take place. This comment, basically, says it all. But provided you had to write your own implementation: - why use a macro? - why use malloc? - what's wrong with mp_snprint, and if the problem is that it doesn't properly escape non-printable characters, why not fix it to escape these or implement a version which does? -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov