From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 1BAF02BD9E for ; Fri, 5 Apr 2019 01:49:13 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8OgR6qhEkhbL for ; Fri, 5 Apr 2019 01:49:13 -0400 (EDT) Received: from smtp29.i.mail.ru (smtp29.i.mail.ru [94.100.177.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 6DC8F2B837 for ; Fri, 5 Apr 2019 01:49:12 -0400 (EDT) Date: Fri, 5 Apr 2019 08:49:07 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH] sql: fix extra type calculation before bytecode generation Message-ID: <20190405054907.GC7691@chai> References: <20190405000627.58693-1-korablev@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190405000627.58693-1-korablev@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: v.shpilevoy@tarantool.org, Nikita Pettik * Nikita Pettik [19/04/05 06:36]: > In SQL type of constant literal (e.g. 1, 2.5, 'abc') is assigned right > after parsing and saving into struct Expr. Occasionally, type is > re-assigned before emitting opcodes to store literal into VDBE memory. > What is more, for floating point number type is changed to "integer". > This patch fixes this obvious misbehaviour. LGTM (for 2.1) -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov