From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vdavydov.dev@gmail.com>
Date: Thu, 4 Apr 2019 19:11:20 +0300
From: Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [PATCH v2 3/3] box: remove _sql_stat1 and _sql_stat4 system
 tables
Message-ID: <20190404161120.lycknoar6elfh3ct@esperanza>
References: <cover.1554310018.git.imeevma@gmail.com>
 <8907dd9a025b0cafe9858289e4e3e2d64618f12b.1554310018.git.imeevma@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8907dd9a025b0cafe9858289e4e3e2d64618f12b.1554310018.git.imeevma@gmail.com>
To: imeevma@tarantool.org
Cc: tarantool-patches@freelists.org
List-ID: <tarantool-patches.dev.tarantool.org>

On Wed, Apr 03, 2019 at 07:58:38PM +0300, imeevma@tarantool.org wrote:
> New version:
> 
> commit 8907dd9a025b0cafe9858289e4e3e2d64618f12b
> Author: Mergen Imeev <imeevma@gmail.com>
> Date:   Wed Apr 3 19:05:09 2019 +0300

When you insert a patch into an email like this, please use
`git show --format=email` so that one can apply it.

> 
>     box: remove _sql_stat1 and _sql_stat4 system tables
>     
>     These tables won't be used anymore and should be deleted.
>     
>     This patch breaks backward compatibility.

This statement deserves an explanation:

	Note, this patch breaks backward compatibility between 2.1.1 and 2.1.2,
	but that's okay as 2.1.1 was beta and we didn't recommend anyone to use
	it.

Or something like this.

The patch itself is okay although I'd squash it with patch 2.