From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vdavydov.dev@gmail.com>
Date: Thu, 4 Apr 2019 15:21:42 +0300
From: Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [PATCH 03/13] vinyl: store tuple comparison hints in tx write set
Message-ID: <20190404122142.qixfydydgovaivuj@esperanza>
References: <cover.1554225074.git.vdavydov.dev@gmail.com>
 <a74b147d1bdf8c8c919f02b3c909cd2ce9d112d6.1554225074.git.vdavydov.dev@gmail.com>
 <20190404114117.GB28969@chai>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190404114117.GB28969@chai>
To: Konstantin Osipov <kostja.osipov@gmail.com>
Cc: tarantool-patches@freelists.org
List-ID: <tarantool-patches.dev.tarantool.org>

On Thu, Apr 04, 2019 at 02:41:17PM +0300, Konstantin Osipov wrote:
> * Vladimir Davydov <vdavydov.dev@gmail.com> [19/04/02 20:35]:
> > This patch incorporates tuple comparison hints into the transaction
> > write set. Now, beside a statement, each txv also stores its hint,
> > which is used in all comparison operations.
> 
> Actually, the more I look at this patch set the more an object
> representing a pair <tuple, hint> (vy_key?) is called for.
> Please consider adding it, it could be passed around by value.

This could be reasonable, but I don't quite like the name vy_key,
because in vinyl we have a different concept of keys.

A few names that pop into mind:

	vy_kv.{stmt,val}
	vy_hinted_stmt.{tuple,val}
	vy_indexed_stmt.{tuple,val}

Any other suggestions?

Will have to rework this patch set, I guess :(