From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kostja.osipov@gmail.com>
Return-Path: <kostja.osipov@gmail.com>
Date: Thu, 4 Apr 2019 14:42:32 +0300
From: Konstantin Osipov <kostja.osipov@gmail.com>
Subject: Re: [PATCH 04/13] vinyl: store tuple comparison hints in tx read set
Message-ID: <20190404114232.GC28969@chai>
References: <cover.1554225074.git.vdavydov.dev@gmail.com>
 <dacb93c54a0f87e728973ce8bb616046acf0de4d.1554225074.git.vdavydov.dev@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <dacb93c54a0f87e728973ce8bb616046acf0de4d.1554225074.git.vdavydov.dev@gmail.com>
To: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: tarantool-patches@freelists.org
List-ID: <tarantool-patches.dev.tarantool.org>

* Vladimir Davydov <vdavydov.dev@gmail.com> [19/04/02 20:35]:
> This patch incorporates tuple comparison hints into the transaction
> read set. Now, beside a statement, each read interval also stores hints
> of boundary statements, which are used in all comparison operations.
> 
> Apart from speeding up lookups, this is also needed for multikey index
> support, because multikey indexes will reuse hints to store offsets of
> indexed array entries.

OK to push.

> --- a/src/box/vy_read_set.h
> +++ b/src/box/vy_read_set.h
> @@ -39,6 +39,7 @@
>  #define RB_COMPACT 1
>  #include <small/rb.h>
>  
> +#include "key_def.h"

Isn't it better to define hint_t in tuple_compare.h to avoid extra
includes?

-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov