From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kostja.osipov@gmail.com>
Return-Path: <kostja.osipov@gmail.com>
Date: Thu, 4 Apr 2019 12:48:09 +0300
From: Konstantin Osipov <kostja.osipov@gmail.com>
Subject: Re: [PATCH 01/13] vinyl: store tuple comparison hints in memory tree
Message-ID: <20190404094809.GA15297@chai>
References: <cover.1554225074.git.vdavydov.dev@gmail.com>
 <a6542464888acd165f49042fdda088a6d4a0c98a.1554225074.git.vdavydov.dev@gmail.com>
 <20190404085327.GB13709@chai>
 <20190404090922.vbg5nqfk75czb77n@esperanza>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190404090922.vbg5nqfk75czb77n@esperanza>
To: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: tarantool-patches@freelists.org
List-ID: <tarantool-patches.dev.tarantool.org>

* Vladimir Davydov <vdavydov.dev@gmail.com> [19/04/04 12:12]:
> > vy_mem_tree_iterator_is_eof()
> > vy_mem_tree_eof
> > 
> > or:
> > 
> > vy_mem_tree_iterator_is_eof()
> > vy_mem_tree_null
> 
> I called it 'invalid' to be consistent with the BPS tree API, see
> bps_tree_invalid_iterator.
> 
> Also, it's used not only for EOF - we set the iterator position to
> this value before iteration is started.
> 
> That said, I'd rather leave the name as is.

I'd rename it across the board.

-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov