From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 4 Apr 2019 11:14:42 +0300 From: Vladimir Davydov Subject: Re: [tarantool-patches] [PATCH v2 1/2] lua: add luaT_tuple_new() Message-ID: <20190404081442.zorje2f3w3m2eiyx@esperanza> References: <0ed648fe2e39100e534d8b6879ce61981f6b82a7.1553696707.git.kshcherbatov@tarantool.org> <20190403180123.w3hvz3hzqk6kwyys@esperanza> <20190404025122.766bkifzjqyjrrk5@tkn_work_nb> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190404025122.766bkifzjqyjrrk5@tkn_work_nb> To: Alexander Turenko Cc: Kirill Shcherbatov , tarantool-patches@freelists.org List-ID: On Thu, Apr 04, 2019 at 05:51:22AM +0300, Alexander Turenko wrote: > On Wed, Apr 03, 2019 at 09:01:23PM +0300, Vladimir Davydov wrote: > > On Wed, Mar 27, 2019 at 05:29:27PM +0300, Kirill Shcherbatov wrote: > > > From: Alexander Turenko > > > > > > The function allows to create a tuple with specific tuple format in C > > > code using a Lua table, another tuple, or objects on a Lua stack. > > > > > > Needed for #3276, #3398, #4025 > > > --- > > > src/box/lua/space.cc | 7 +- > > > src/box/lua/tuple.c | 58 +++++++---- > > > src/box/lua/tuple.h | 15 ++- > > > test/unit/CMakeLists.txt | 4 + > > > test/unit/luaT_tuple_new.c | 178 ++++++++++++++++++++++++++++++++ > > > test/unit/luaT_tuple_new.result | 22 ++++ > > > 6 files changed, 261 insertions(+), 23 deletions(-) > > > create mode 100644 test/unit/luaT_tuple_new.c > > > create mode 100644 test/unit/luaT_tuple_new.result > > > > Pushed to master. > > Thanks! You're welcome) > > Are there any problems with pushing to 2.1 and 1.10? I need this for > merger, which is planned to land into 1.10. Let's think about backporting this patch to 2.1 and 1.10 after we push the merger to master.