From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kostja@tarantool.org>
Date: Thu, 4 Apr 2019 09:19:44 +0300
From: Konstantin Osipov <kostja@tarantool.org>
Subject: Re: [tarantool-patches] [PATCH v3 3/7] box: move offset_slot init to
 tuple_format_add_field
Message-ID: <20190404061944.GC1116@chai>
References: <cover.1554218695.git.kshcherbatov@tarantool.org>
 <60775a575969680c7ee61e88bb1bb0a3ae95bd7a.1554218695.git.kshcherbatov@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <60775a575969680c7ee61e88bb1bb0a3ae95bd7a.1554218695.git.kshcherbatov@tarantool.org>
To: tarantool-patches@freelists.org
Cc: vdavydov.dev@gmail.com, Kirill Shcherbatov <kshcherbatov@tarantool.org>
List-ID: <tarantool-patches.dev.tarantool.org>

* Kirill Shcherbatov <kshcherbatov@tarantool.org> [19/04/02 19:27]:
> Due to the fact that the allocation of offset_slot in the case of
> multikey indexes will become more complicated and will be
> necessary for intermediate nodes of the tuple_field tree, we must
> move this logic to the tuple_format_add_field that performs
> an intermediate nodes allocation for a JSON path.

I actually had a nit about this patch, I think 3 goto labels in
such a simple function is a bit of an overkill - the code is
harder to follow than necessary. I would ditch the 'cleanup'
label, this would make the code simpler.