From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kostja@tarantool.org>
Date: Thu, 4 Apr 2019 09:17:18 +0300
From: Konstantin Osipov <kostja@tarantool.org>
Subject: Re: [tarantool-patches] Re: [PATCH v3 2/7] lib: introduce a new
 json_path_multikey_offset helper
Message-ID: <20190404061718.GB1116@chai>
References: <cover.1554218695.git.kshcherbatov@tarantool.org>
 <b5db9e081712c8968c3f2e9f36b726031c76e8e0.1554218695.git.kshcherbatov@tarantool.org>
 <20190403125601.unoe7qjdl6clqd55@esperanza>
 <6becaa9e-9d2f-1fbe-7748-9c04b016b45f@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <6becaa9e-9d2f-1fbe-7748-9c04b016b45f@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Vladimir Davydov <vdavydov.dev@gmail.com>
List-ID: <tarantool-patches.dev.tarantool.org>

* Kirill Shcherbatov <kshcherbatov@tarantool.org> [19/04/03 21:37]:
> > IMO returning path_len if no multikey token is found would be more
> > common (think of STL methods, which return end() iterator if not found).
> > Doesn't really matter though.
> > 
> > Other than that looks good to me.
> 
> I don't mind. Updated version is on the branch.

I agree, since "not found" is not an error, it's search result.


-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov