From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 3 Apr 2019 20:19:00 +0300 From: Vladimir Davydov Subject: Re: [PATCH v2 3/3] box: remove _sql_stat1 and _sql_stat4 system tables Message-ID: <20190403171900.tbkhlf5h5ebvs36f@esperanza> References: <8907dd9a025b0cafe9858289e4e3e2d64618f12b.1554310018.git.imeevma@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8907dd9a025b0cafe9858289e4e3e2d64618f12b.1554310018.git.imeevma@gmail.com> To: imeevma@tarantool.org Cc: tarantool-patches@freelists.org List-ID: On Wed, Apr 03, 2019 at 07:58:38PM +0300, imeevma@tarantool.org wrote: > >> diff --git a/src/box/sql.c b/src/box/sql.c > >> index 4fac020..7beeee1 100644 > >> --- a/src/box/sql.c > >> +++ b/src/box/sql.c > >> @@ -87,7 +87,7 @@ sql_load_schema() > >> * statistics (_sql_stat1 and _sql_stat4). Thus, we can > >> * skip statistics loading. > >> */ > >> - struct space *stat = space_by_id(BOX_SQL_STAT1_ID); > >> + struct space *stat = space_by_name("_sql_stat1"); > > > > I don't understand this change: even though you removed the tables you > > still expect them to be accessible by name here and in a few other > > places. At any rate, the comment above needs to be refreshed. > > > I did this to free BOX_SQL_STAT1_ID and BOX_SQL_STAT4_ID so I > could remove them. These functions are currently unused. Moved > this fix to a different commit. Okay. Still, I don't understand how this is supposed to work at all: the tables have been removed, but the code using them is still there - it just refers to them by name instead of id now.