From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 3 Apr 2019 15:57:27 +0300 From: Vladimir Davydov Subject: Re: [PATCH v3 3/7] box: move offset_slot init to tuple_format_add_field Message-ID: <20190403125727.wnbaxoyyohvuptcl@esperanza> References: <60775a575969680c7ee61e88bb1bb0a3ae95bd7a.1554218695.git.kshcherbatov@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <60775a575969680c7ee61e88bb1bb0a3ae95bd7a.1554218695.git.kshcherbatov@tarantool.org> To: Kirill Shcherbatov Cc: tarantool-patches@freelists.org List-ID: On Tue, Apr 02, 2019 at 06:49:34PM +0300, Kirill Shcherbatov wrote: > Due to the fact that the allocation of offset_slot in the case of > multikey indexes will become more complicated and will be > necessary for intermediate nodes of the tuple_field tree, we must > move this logic to the tuple_format_add_field that performs > an intermediate nodes allocation for a JSON path. > > Needed for #1257 > --- > src/box/tuple_format.c | 34 ++++++++++++++++++---------------- > 1 file changed, 18 insertions(+), 16 deletions(-) Trivial. Looks okay to me.