From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id D1B5B2AF17 for ; Wed, 3 Apr 2019 03:58:48 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Nl36s8URearv for ; Wed, 3 Apr 2019 03:58:48 -0400 (EDT) Received: from smtp43.i.mail.ru (smtp43.i.mail.ru [94.100.177.103]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 8F5042AEFB for ; Wed, 3 Apr 2019 03:58:48 -0400 (EDT) Date: Wed, 3 Apr 2019 10:58:46 +0300 From: Kirill Yukhin Subject: [tarantool-patches] Re: [PATCH 0/2] SQL types fixes Message-ID: <20190403075846.vol7cgvl5jy6qvfo@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: v.shpilevoy@tarantool.org, Nikita Pettik Hello, On 11 Mar 21:10, Nikita Pettik wrote: > Branch: https://github.com/tarantool/tarantool/tree/np/sql-types-fixes > No related issue > > First patch fixes names send as column meta-information. After > BLOB type was substituted with SCALAR, it can be confusing saying > that column has type BLOB. Moreover, other string represantations > have been replaced with exact names of NoSQL types (i.e. STRING, > NUMER etc). > > Second patch fixes wrong type calculation for returning value for > function: it takes place during name resolution, and its second > promotion during byte-code generation is redundant (and in some > cases is wrong). > > Nikita Pettik (2): > sql: make type in column-meta be consistent with NoSQL names > sql: don't change type of function's retval after codegen I've checked the patchset into master and 2.1 branch. -- Regards, Kirill Yukhin