From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id DEF9D2B128 for ; Tue, 2 Apr 2019 20:31:08 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ikz8fpwmr1_l for ; Tue, 2 Apr 2019 20:31:08 -0400 (EDT) Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 9494C2B112 for ; Tue, 2 Apr 2019 20:31:08 -0400 (EDT) Date: Wed, 3 Apr 2019 03:31:00 +0300 From: Alexander Turenko Subject: [tarantool-patches] Re: [PATCH] test: temporary disable sql-tap/collation_unicode Message-ID: <20190403003100.kcnjj3rdar5jifg2@tkn_work_nb> References: <4dfa31f79de0d2f294fc484dbbb2b89cf7c57a11.1554250634.git.alexander.turenko@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <4dfa31f79de0d2f294fc484dbbb2b89cf7c57a11.1554250634.git.alexander.turenko@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: Stanislav Zudin Pushed to master and 2.1. Reopened the issue. WBR, Alexander Turenko. On Wed, Apr 03, 2019 at 03:21:15AM +0300, Alexander Turenko wrote: > The test was introduced in a99d7a0c0f6a16f0f51be532f0543e3fe1f9c97b > ('Feature request for a new collation'). It succeeds when tarantool is > linked with a fresh libicu version, but fails with older ones. At least: > > * dev-libs/icu-63.1-r1 (Gentoo) -- passes; > * libicu.x86_64 50.1.2-15.el7 (CentOS 7.4) -- fails. > > We need to handle different behaviours of libicu versions somehow, maybe > add only stable subset of collations. This will also fix the test and > then it will be enabled back. > > Related to #4007. > --- > > https://github.com/tarantool/tarantool/issues/4007 > https://github.com/tarantool/tarantool/tree/Totktonada/disable-collation-unicode-test > > test/sql-tap/suite.ini | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/test/sql-tap/suite.ini b/test/sql-tap/suite.ini > index 95207f439..e3e483851 100644 > --- a/test/sql-tap/suite.ini > +++ b/test/sql-tap/suite.ini > @@ -20,6 +20,7 @@ disabled = selectA.test.lua ; > analyzeD.test.lua ; > analyzeE.test.lua ; > analyzeF.test.lua ; > + collation_unicode.test.lua ; > > lua_libs = lua/sqltester.lua ../sql/lua/sql_tokenizer.lua ../box/lua/identifier.lua > is_parallel = True > -- > 2.20.1 >