From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 2 Apr 2019 20:09:54 +0300 From: Vladimir Davydov Subject: Re: [PATCH v1 1/1] vinyl: fix invalid tuple in surrogate delete Message-ID: <20190402170953.th6dajfy5etqjztb@esperanza> References: <18ddbffc8d63755281e4d4a8366adcded58da720.1554202702.git.kshcherbatov@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <18ddbffc8d63755281e4d4a8366adcded58da720.1554202702.git.kshcherbatov@tarantool.org> To: Kirill Shcherbatov Cc: tarantool-patches@freelists.org List-ID: On Tue, Apr 02, 2019 at 01:59:11PM +0300, Kirill Shcherbatov wrote: > If the map contains non-string keys that cannot be used in the > JSON index, an incorrect tuple is created in > vy_stmt_new_surrogate_delete_raw during the construction of the > surrogate tuple. This occurs because the number of items that > the map contains has already been copied, while such invalid > key-value pairs are not copied. > The poblem is resolved through the creation of dummy nil:nil > pairs in such cases. > --- > https://github.com/tarantool/tarantool/tree/kshch/surrogate-delete-raw-fixup > > src/box/vy_stmt.c | 3 +++ > test/engine/json.result | 22 ++++++++++++++++++++++ > test/engine/json.test.lua | 9 +++++++++ > 3 files changed, 34 insertions(+) Pushed to master, thanks.