From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 9D6592A1DE for ; Tue, 2 Apr 2019 04:55:05 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Tcar5Mj8eC5y for ; Tue, 2 Apr 2019 04:55:05 -0400 (EDT) Received: from smtp52.i.mail.ru (smtp52.i.mail.ru [94.100.177.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 55DD3250F7 for ; Tue, 2 Apr 2019 04:55:05 -0400 (EDT) Date: Tue, 2 Apr 2019 11:55:02 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH v10 3/4] sql: create box.execute() Message-ID: <20190402085502.GO25072@chai> References: <4b3ca18628a2ed3d0cbf70c4e0d0e6e182fa33ad.1554148476.git.v.shpilevoy@tarantool.org> <20190402082110.GM25072@chai> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: kyukhin@tarantool.org, Mergen Imeev * Imeev Mergen [19/04/02 11:34]: Sure. > On 4/2/19 11:21 AM, Konstantin Osipov wrote: > > * Vladislav Shpilevoy [19/04/01 23:03]: > > > + luaL_pushuint64(L, db->nChange); > > > + lua_setfield(L, -2, "rowcount"); > > Another small nit is about this name. We write > > IPROTO_SQL_ROW_COUNT as a key name, but rowcount (note no > > underscore) in Lua. I would either use a consistent naming (either > > with or without underscore), or, better yet, find a name which > > doesn't provoke confusion. > > Considering we use autoincrement_ids (notice absence of space > > after auto), I'd call the member row_count. > > > > > Do you mind if I do this as follow up separate patch? Also I plan > to use sql_info_key_strs in netbox_decode_sql_info() and > port_sql_dump_lua() for this. > -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov