From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 47E1B2552A
	for <tarantool-patches@freelists.org>; Tue,  2 Apr 2019 03:52:20 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id tsGAYU-vr93u for <tarantool-patches@freelists.org>;
	Tue,  2 Apr 2019 03:52:20 -0400 (EDT)
Received: from smtp52.i.mail.ru (smtp52.i.mail.ru [94.100.177.112])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id EF30425443
	for <tarantool-patches@freelists.org>; Tue,  2 Apr 2019 03:52:19 -0400 (EDT)
Date: Tue, 2 Apr 2019 10:52:17 +0300
From: Konstantin Osipov <kostja@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH 07/13] sql: arithmetic functions
 support big integers
Message-ID: <20190402075217.GF25072@chai>
References: <cover.1552663061.git.szudin@tarantool.org>
 <cover.1552663061.git.szudin@tarantool.org>
 <a75f053d0e2c97d7b629c8f22365e8585ccb1be3.1552663061.git.szudin@tarantool.org>
 <A2089B11-9879-4DEB-9A7A-CBB657211CA5@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <A2089B11-9879-4DEB-9A7A-CBB657211CA5@tarantool.org>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-Help: <mailto:ecartis@freelists.org?Subject=help>
List-Unsubscribe: <mailto:tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-Subscribe: <mailto:tarantool-patches-request@freelists.org?Subject=subscribe>
List-Owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-Archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org
Cc: szudin@tarantool.org

* n.pettik <korablev@tarantool.org> [19/03/25 18:13]:
> > +enum arithmetic_result sqlAddInt64(i64 *, bool, i64, bool);
> > +enum arithmetic_result sqlSubInt64(i64 *, bool, i64, bool);
> > +enum arithmetic_result sqlMulInt64(i64 *, bool, i64, bool);
> > +enum arithmetic_result sqlDivInt64(i64 *, bool, i64, bool);
> > +enum arithmetic_result sqlRemInt64(i64 *, bool, i64, bool);

I think we should not introduce a separate enum for this, the
convention should be:

-1 + diag_set for errors

- the argument list should be designed in a way to make the
  functions composable. E.g. if you input bool is_signed as input,
  it should return bool is_signed for output. 

-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov