From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 74819251E3 for ; Tue, 2 Apr 2019 03:46:50 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7v5zhn34_lqW for ; Tue, 2 Apr 2019 03:46:50 -0400 (EDT) Received: from smtp46.i.mail.ru (smtp46.i.mail.ru [94.100.177.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 2D3F220081 for ; Tue, 2 Apr 2019 03:46:48 -0400 (EDT) Date: Tue, 2 Apr 2019 10:46:46 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH 04/13] sql: support big integers within sql binding Message-ID: <20190402074646.GE25072@chai> References: <7B68C4B8-A53B-483E-AD57-8A746682FD73@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7B68C4B8-A53B-483E-AD57-8A746682FD73@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: szudin@tarantool.org * n.pettik [19/03/25 18:13]: > > + > > + SQL_BLOB, /* 0x20 */ > > + SQL_NULL, /* 0x21 */ > > + SQL_TEXT, /* 0x22 */ > > + SQL_NULL, /* 0x23 */ > > + SQL_UNSIGNED, /* 0x24 */ > > + SQL_NULL, /* 0x25 */ > > + SQL_UNSIGNED, /* 0x26 */ > > + SQL_NULL, /* 0x27 */ > > + SQL_FLOAT, /* 0x28 */ > > + SQL_NULL, /* 0x29 */ > > + SQL_FLOAT, /* 0x2a */ > > + SQL_NULL, /* 0x2b */ > > + SQL_INTEGER, /* 0x2c */ > > + SQL_NULL, /* 0x2d */ > > + SQL_INTEGER, /* 0x2e */ > > + SQL_NULL, /* 0x2f */ > > + SQL_BLOB, /* 0x30 */ > > + SQL_NULL, /* 0x31 */ > > + SQL_TEXT, /* 0x32 */ > > + SQL_NULL, /* 0x33 */ > > + SQL_INTEGER, /* 0x34 */ > > + SQL_NULL, /* 0x35 */ > > + SQL_INTEGER, /* 0x36 */ > > + SQL_NULL, /* 0x37 */ > > + SQL_FLOAT, /* 0x38 */ > > + SQL_NULL, /* 0x39 */ > > + SQL_FLOAT, /* 0x3a */ > > + SQL_NULL, /* 0x3b */ > > + SQL_INTEGER, /* 0x3c */ > > + SQL_NULL, /* 0x3d */ > > + SQL_INTEGER, /* 0x3e */ > > + SQL_NULL, /* 0x3f */ > > Looks terrible. Could we rework this mechanism of fetching type? > Soon we are going to add several types more, so the size of array > will become enormous. I hope we can kill this array altogether as well as mem flags and use a combination of mp_type and enum field_type wherever possible. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov