From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Return-Path: <gorcunov@gmail.com>
Date: Tue, 2 Apr 2019 01:05:16 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Subject: Re: [PATCH 2/2] lib/core/fiber: Allow to extend default stack size
Message-ID: <20190401220516.GF2431@uranus.lan>
References: <20190319193845.31221-1-gorcunov@gmail.com>
 <20190319193845.31221-3-gorcunov@gmail.com>
 <20190327093506.zsxzchje2un76rcp@esperanza>
 <20190327094618.GH20626@uranus.lan>
 <20190327101552.d3b6xvezm3rigszm@esperanza>
 <20190327102333.GJ20626@uranus.lan>
 <20190401174114.GD2431@uranus.lan>
 <20190401185845.GA21609@chai>
 <20190401191909.GE2431@uranus.lan>
 <20190401205109.GA23775@chai>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190401205109.GA23775@chai>
To: Konstantin Osipov <kostja@tarantool.org>
Cc: tml <tarantool-patches@freelists.org>, Vladimir Davydov <vdavydov.dev@gmail.com>
List-ID: <tarantool-patches.dev.tarantool.org>

On Mon, Apr 01, 2019 at 11:51:09PM +0300, Konstantin Osipov wrote:
> 
> I don't think we should bother with making sure the stack is right
> for all fibers. You set the stack size, then you start fibers
> which depend on it.

Kostja, "require('fiber').cfg{stack_size=value})" implies that
lua read and parse it, but lua *itself* runs inside a fiber where
we've the stack size already allocated and what is worse its size
is compiled in. Next time when "readline" developers increase *own*
stack size we hit the same bug. Users simply won't have a chance to
run tarantool, instead they will have to wait us to increase default
stack size and rebuild the program.