From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 1 Apr 2019 23:51:09 +0300 From: Konstantin Osipov Subject: Re: [PATCH 2/2] lib/core/fiber: Allow to extend default stack size Message-ID: <20190401205109.GA23775@chai> References: <20190319193845.31221-1-gorcunov@gmail.com> <20190319193845.31221-3-gorcunov@gmail.com> <20190327093506.zsxzchje2un76rcp@esperanza> <20190327094618.GH20626@uranus.lan> <20190327101552.d3b6xvezm3rigszm@esperanza> <20190327102333.GJ20626@uranus.lan> <20190401174114.GD2431@uranus.lan> <20190401185845.GA21609@chai> <20190401191909.GE2431@uranus.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190401191909.GE2431@uranus.lan> To: Cyrill Gorcunov Cc: tml , Vladimir Davydov List-ID: * Cyrill Gorcunov [19/04/01 22:23]: > On Mon, Apr 01, 2019 at 09:58:45PM +0300, Konstantin Osipov wrote: > > * Cyrill Gorcunov [19/04/01 20:44]: > > > > require('fiber').cfg{stack_size=value}) > > Wait, at such early stage we don't have lua initialized yet. > Letme describe the issue again, I think it might lost in threads: > I would like to provide user a way to configure default stack > size so we won't have to recompile tarantool to increase stack > sizes in future. > > I assume we can stick to the idea that every fiber in the > system should have same stack size for simplicity sake. > Since we need known stack size at the early bootstrap stage > (for main_cord, even earlier than we initialize lua) we can't > use traditional cfg engine. Instead we either should use > environment variables, either some configuration file. > > Or I miss something obvious? I don't think we should bother with making sure the stack is right for all fibers. You set the stack size, then you start fibers which depend on it. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov