From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id B8C0B29CDB for ; Mon, 1 Apr 2019 10:15:57 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TGeQQclzVfr7 for ; Mon, 1 Apr 2019 10:15:57 -0400 (EDT) Received: from smtp38.i.mail.ru (smtp38.i.mail.ru [94.100.177.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 6E27C275E2 for ; Mon, 1 Apr 2019 10:15:57 -0400 (EDT) Date: Mon, 1 Apr 2019 17:15:52 +0300 From: Kirill Yukhin Subject: [tarantool-patches] Re: [PATCH 0/2] sql: add better coll. determination & position func. Message-ID: <20190401141551.7jcimhusny2oeugs@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: korablev@tarantool.org, Ivan Koptelov Hello, On 20 Mar 14:11, Ivan Koptelov wrote: > There are two patches in this series. First one enhances > collation determination for function arguments (e.g. for cases, > when function arguments have different collations). Second one > renames instr() to position() and swaps arguments order. Also > after the second patch both arguments must have the same type, > which should be either TEXT or BLOB. > > Branch https://github.com/tarantool/tarantool/tree/sudobobo/gh-3933-add-position-func > Issue https://github.com/tarantool/tarantool/issues/3933 I've checked your patches into master & 2.1 branch. -- Regards, Kirill Yukhin