From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 3A47529669 for ; Mon, 1 Apr 2019 09:05:47 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id k7EYg5biNcRk for ; Mon, 1 Apr 2019 09:05:47 -0400 (EDT) Received: from smtp16.mail.ru (smtp16.mail.ru [94.100.176.153]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 86AFB1FC09 for ; Mon, 1 Apr 2019 09:05:46 -0400 (EDT) Date: Mon, 1 Apr 2019 16:05:44 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH v1 1/1] sql: parameter binding for box.execute() Message-ID: <20190401130544.GA2628@chai> References: <884040abe819e8ec11f7877d15e5482d6a24139b.1553947026.git.imeevma@gmail.com> <20190401052112.GB8239@chai> <648b0ae4-35e0-9df0-1a67-712788727b79@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <648b0ae4-35e0-9df0-1a67-712788727b79@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: Vladislav Shpilevoy Cc: tarantool-patches@freelists.org * Vladislav Shpilevoy [19/04/01 11:45]: > > > On 01/04/2019 08:21, Konstantin Osipov wrote: > > * imeevma@tarantool.org [19/03/30 16:50]: > >> This patch defines parameters binding for SQL statements executed > >> through box.execute(). > > > > Could the dependency on lua_* be moved into src/box/lua/ or that > > would be difficult to do? > > It requires exposure of struct sql_bind into the header file, and > include "execute.h" into one of box/lua files. If you insist, we > can do that. Should we? Yes, in a separate patch. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov