From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id DCD62297F3 for ; Mon, 1 Apr 2019 01:43:13 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Z8mG_iRL-mRr for ; Mon, 1 Apr 2019 01:43:13 -0400 (EDT) Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 9227C29709 for ; Mon, 1 Apr 2019 01:43:13 -0400 (EDT) Date: Mon, 1 Apr 2019 08:43:05 +0300 From: Alexander Turenko Subject: [tarantool-patches] Re: [PATCH] tarantoolctl: remove metatable assumptions in start() Message-ID: <20190401054304.kofvdg3uz6fzwl5d@tkn_work_nb> References: <20190327134014.56676-1-roman.habibov@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190327134014.56676-1-roman.habibov@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: Roman Khabibov Cc: tarantool-patches@freelists.org Commented in the issue, cited here: > @opomuc @olegrok I don't know what are you trying to do here. It seems > you just try to start an instance w/o box.cfg() call inside. I don't > see a reason to support this case. However more meaningful error > message from tarantoolctl start in the case would helpful. > > Re config module errors: I don't know whether you use it correctly. If > so, file another issue to this module. > > https://github.com/tarantool/tarantool/issues/3953#issuecomment-478439448 I propose to consider this issue as a problem with an error message. WBR, Alexander Turenko. On Wed, Mar 27, 2019 at 04:40:14PM +0300, Roman Khabibov wrote: > box.cfg{} metatables are uninitialized when start() called > before box.cfg{}. It led to unexpected error. > > Closes #3953 > --- > Branch: https://github.com/tarantool/tarantool/tree/romanhabibov/gh-3953-tctl > Issue: https://github.com/tarantool/tarantool/issues/3953 > > extra/dist/tarantoolctl.in | 7 ------- > test/app-tap/tarantoolctl.test.lua | 4 +++- > 2 files changed, 3 insertions(+), 8 deletions(-) > > diff --git a/extra/dist/tarantoolctl.in b/extra/dist/tarantoolctl.in > index 47fcf895f..91747e3ba 100755 > --- a/extra/dist/tarantoolctl.in > +++ b/extra/dist/tarantoolctl.in > @@ -547,13 +547,6 @@ local function start() > end > os.exit(1) > end > - local old_call = getmetatable(box.cfg).__call > - getmetatable(box.cfg).__call = function(old_cfg, cfg) > - if old_cfg.pid_file ~= nil and cfg ~= nil and cfg.pid_file ~= nil then > - cfg.pid_file = old_cfg.pid_file So if a user lean on that value (s)he now cannot? > - end > - old_call(old_cfg, cfg) So if a user set a metatable on box.cfg() with __call method, it will not more called? > - end > return 0 > end > > diff --git a/test/app-tap/tarantoolctl.test.lua b/test/app-tap/tarantoolctl.test.lua > index db046e03f..1755fcc66 100755 > --- a/test/app-tap/tarantoolctl.test.lua > +++ b/test/app-tap/tarantoolctl.test.lua > @@ -165,10 +165,12 @@ do > local dir = fio.tempdir() > local code = [[ box.cfg{memtx_memory = 104857600} ]] > create_script(dir, 'script.lua', code) > + create_script(dir, 'init.lua', [[ print('Hi!') ]]) > > local status, err = pcall(function() > test:test("basic test", function(test_i) > - test_i:plan(16) > + test_i:plan(18) > + check_ok(test_i, dir, 'start', 'init.lua', 0, nil, "Starting instance init...") So we're 'successfully' started an instance, it executes a script and then 'tarantoolctl status' and 'tarantoolctl enter' don't show it as running. It does not look as a right behaviour. > check_ok(test_i, dir, 'start', 'script', 0, nil, "Starting instance") > tctl_wait_start(dir, 'script') > check_ok(test_i, dir, 'status', 'script', 0, nil, "is running") > -- > 2.20.1 (Apple Git-117) >