From: Konstantin Osipov <kostja@tarantool.org>
To: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH 5/6] test: differentiate blocked and closed swim fake fds
Date: Fri, 29 Mar 2019 21:25:26 +0300 [thread overview]
Message-ID: <20190329182526.GD20712@chai> (raw)
In-Reply-To: <aaafcbb19c32bd4358a55c4249fd37d098a606d6.1553078631.git.v.shpilevoy@tarantool.org>
* Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [19/03/20 14:11]:
> SWIM's fake file descriptors were implemented to test SWIM with
> virtual time and fully controlled network with immediate packet
> delivery. One of their features - API to block a file descriptor
> and test various failures about it.
>
> But blocked fake fd looks the same as closed fd, and it can
> confuse new test's author. Now if an fd is not unblocked at the
> end of a test, it leads to a crash. This commit fixes that via
> adding explicit difference between blocked and closed fd.
>
> Part of #3234
OK to push.
--
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov
next prev parent reply other threads:[~2019-03-29 18:25 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 10:49 [tarantool-patches] [PATCH 0/6] SWIM failure detection draft Vladislav Shpilevoy
2019-03-20 10:49 ` [tarantool-patches] [PATCH 1/6] swim: follow-ups for SWIM anti-entropy Vladislav Shpilevoy
2019-03-29 8:27 ` [tarantool-patches] " Konstantin Osipov
2019-03-29 10:19 ` Vladislav Shpilevoy
2019-03-20 10:49 ` [tarantool-patches] [PATCH 2/6] test: introduce breakpoints for swim's event loop Vladislav Shpilevoy
2019-03-29 18:20 ` [tarantool-patches] " Konstantin Osipov
2019-04-02 12:25 ` Vladislav Shpilevoy
2019-04-02 19:16 ` Vladislav Shpilevoy
2019-04-02 20:40 ` Konstantin Osipov
2019-04-02 21:26 ` Vladislav Shpilevoy
2019-03-20 10:49 ` [tarantool-patches] [PATCH 3/6] test: remove swim_unblock_fd event from swim test harness Vladislav Shpilevoy
2019-03-29 18:22 ` [tarantool-patches] " Konstantin Osipov
2019-04-02 21:26 ` Vladislav Shpilevoy
2019-03-20 10:49 ` [tarantool-patches] [PATCH 4/6] swim: expose enum swim_member_status to public API Vladislav Shpilevoy
2019-03-29 18:24 ` [tarantool-patches] " Konstantin Osipov
2019-04-02 12:25 ` Vladislav Shpilevoy
2019-04-02 13:17 ` Konstantin Osipov
2019-04-02 21:26 ` Vladislav Shpilevoy
2019-03-20 10:49 ` [tarantool-patches] [PATCH 5/6] test: differentiate blocked and closed swim fake fds Vladislav Shpilevoy
2019-03-29 18:25 ` Konstantin Osipov [this message]
2019-04-02 21:26 ` [tarantool-patches] " Vladislav Shpilevoy
2019-03-20 10:49 ` [tarantool-patches] [PATCH 6/6] [RAW] swim: introduce failure detection component Vladislav Shpilevoy
2019-03-29 18:59 ` [tarantool-patches] " Konstantin Osipov
2019-04-02 12:25 ` Vladislav Shpilevoy
2019-04-04 10:20 ` Vladislav Shpilevoy
2019-04-04 12:45 ` Konstantin Osipov
2019-04-04 13:57 ` Vladislav Shpilevoy
2019-04-04 16:14 ` Vladimir Davydov
2019-04-04 16:47 ` Vladislav Shpilevoy
2019-03-27 19:28 ` [tarantool-patches] [PATCH 7/6] swim: make swim_upsert_member returning two values Vladislav Shpilevoy
2019-03-28 8:52 ` [tarantool-patches] " Konstantin Osipov
2019-03-28 11:52 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190329182526.GD20712@chai \
--to=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH 5/6] test: differentiate blocked and closed swim fake fds' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox