From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id B6BB42B529 for ; Fri, 29 Mar 2019 14:24:34 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wn0OIcGNmWQ1 for ; Fri, 29 Mar 2019 14:24:34 -0400 (EDT) Received: from smtp62.i.mail.ru (smtp62.i.mail.ru [217.69.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 74E882B50E for ; Fri, 29 Mar 2019 14:24:34 -0400 (EDT) Received: from [185.6.245.178] (port=34410 helo=atlas.local) by smtp62.i.mail.ru with esmtpa (envelope-from ) id 1h9wB6-0003yd-W1 for tarantool-patches@freelists.org; Fri, 29 Mar 2019 21:24:33 +0300 Date: Fri, 29 Mar 2019 21:24:32 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH 4/6] swim: expose enum swim_member_status to public API Message-ID: <20190329182432.GC20712@chai> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org * Vladislav Shpilevoy [19/03/20 14:11]: > At least for testing it is necessary to be able to get status of > a member. Now it is always 'alive', but forthcoming > failure-detection component would change it. > +#define SWIM_PUBLIC_API > +#include "swim_proto.h" Please rather than using a define kludge introduce swim_constants.h and move the declaration there. Make swim_constants.h part of the public api. Otherwise OK to push. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov