From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 559342AD01 for ; Fri, 29 Mar 2019 08:01:41 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id A23b5lV3-fwv for ; Fri, 29 Mar 2019 08:01:41 -0400 (EDT) Received: from smtp32.i.mail.ru (smtp32.i.mail.ru [94.100.177.92]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 117C32ACEF for ; Fri, 29 Mar 2019 08:01:40 -0400 (EDT) Date: Fri, 29 Mar 2019 15:01:39 +0300 From: Kirill Yukhin Subject: [tarantool-patches] Re: [PATCH v9 2/7] sql: fix error code for SQL errors in execute.c Message-ID: <20190329120138.vgww5uradvxzim3f@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: v.shpilevoy@tarantool.org Hello, On 22 Mar 13:50, imeevma@tarantool.org wrote: > Currently, functions sql_execute() and sql_prepare_and_execute() > set the ER_SQL_EXECUTE code for all errors that occur during the > execution of a SQL command. This is considered incorrect because > some of these errors may have their own error code. > > In addition, all errors that do not have an error code are VDBE > errors due to issue #3965, so it makes sense to set the error > code ER_VDBE_EXECUTE for all errors without an error code. > > Part of #3505 I've checked your patch into master. -- Reagrds, Kirill Yukhin