From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vdavydov.dev@gmail.com>
Date: Thu, 28 Mar 2019 19:03:37 +0300
From: Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [PATCH v2 1/3] vinyl: make tx_manager_abort_writers_for_ddl more
 thorough
Message-ID: <20190328160337.zpne4bckh7cxxkb2@esperanza>
References: <cover.1553787937.git.vdavydov.dev@gmail.com>
 <1574fba56e436ce5129fc0a2853afb3f8c946279.1553787937.git.vdavydov.dev@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1574fba56e436ce5129fc0a2853afb3f8c946279.1553787937.git.vdavydov.dev@gmail.com>
To: kostja@tarantool.org
Cc: tarantool-patches@freelists.org
List-ID: <tarantool-patches.dev.tarantool.org>

On Thu, Mar 28, 2019 at 06:52:27PM +0300, Vladimir Davydov wrote:
> diff --git a/src/box/vinyl.c b/src/box/vinyl.c
> index 3ef43e18..24f900cb 100644
> --- a/src/box/vinyl.c
> +++ b/src/box/vinyl.c
> @@ -2433,8 +2433,10 @@ vinyl_engine_begin_statement(struct engine *engine, struct txn *txn)
>  	(void)engine;
>  	struct vy_tx *tx = txn->engine_tx;
>  	struct txn_stmt *stmt = txn_current_stmt(txn);
> +	struct index *pk = space_index(stmt->space, 0);
>  	assert(tx != NULL);
> -	return vy_tx_begin_statement(tx, &stmt->engine_savepoint);
> +	return vy_tx_begin_statement(tx, pk != NULL ? vy_lsm(pk) : NULL,
> +				     &stmt->engine_savepoint);

Argh. On the second thought, this looks kinda ugly. I'll use space ptr
instead as you suggested initiallly, so that you can take your pick.
Stay tuned for v3.