From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 28 Mar 2019 17:43:00 +0300 From: Vladimir Davydov Subject: Re: [tarantool-patches] Re: [PATCH 2/2] vinyl: fail aborted transactions early Message-ID: <20190328144300.gzod7r5b2t75epht@esperanza> References: <6a374b13b7dc52ce14d8d23433efd46f3e2161cf.1553277782.git.vdavydov.dev@gmail.com> <20190328140557.GC11518@chai> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190328140557.GC11518@chai> To: Konstantin Osipov Cc: tarantool-patches@freelists.org List-ID: On Thu, Mar 28, 2019 at 05:05:57PM +0300, Konstantin Osipov wrote: > * Vladimir Davydov [19/03/22 21:17]: > > We abort transactions when switching to read-only mode, building a new > > index, or reverting a statement after a failed WAL write. It's no use > > to allow an aborted transaction to proceed as usual until commit - we > > should fail it as early as we can to avoid wasting resources. Currently, > > we do it in a rather abrupt way - by an assertion :-) This patch makes > > any DML/DQL operation fail gracefully instead. > > Closes #4070 > > OK to push. Pushed both patches to master, 2.1, and 1.10.