[tarantool-patches] Re: [PATCH 5/6] vinyl: run iterator: refactor seek method

[Konstantin Osipov <kostja@tarantool.org>]

* Vladimir Davydov <vdavydov.dev@gmail.com> [19/03/26 18:56]:
> A few changes to make the function more straightforward:
> 
>  - Move bloom checking and LSN filtering out of 'do_seek' helper. Make
>    the helper do just one simple task - lookup the first one in a series
>    of statements matching the given search criteria.
>  - Fold iterator type and key substitution in 'seek' method, similarly
>    to how we did it for other iterators.
>  - Cleanup EQ checks. Use the original iterator type and key where
>    appropriate to remove extra checks in calling methods. Don't check EQ
>    in 'seek' method in case it was checked by 'do_seek'.
>  - Add some comments.

LGTM (same comment re passing EOF in return value applies).
eq_found looks cumbersome, perhaps you could both kill bool
eq_found and not pass eof in the out parameter of do_seek()?


-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov