From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 5EBAB2AFE2 for ; Thu, 28 Mar 2019 10:35:20 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ueobXV9VJ6bQ for ; Thu, 28 Mar 2019 10:35:20 -0400 (EDT) Received: from smtp51.i.mail.ru (smtp51.i.mail.ru [94.100.177.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 15FDB27AE2 for ; Thu, 28 Mar 2019 10:35:19 -0400 (EDT) Received: by smtp51.i.mail.ru with esmtpa (envelope-from ) id 1h9W7i-0007JH-5s for tarantool-patches@freelists.org; Thu, 28 Mar 2019 17:35:18 +0300 Date: Thu, 28 Mar 2019 17:35:18 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH 4/6] vinyl: run iterator: zap search_ended flag Message-ID: <20190328143518.GD23295@chai> References: <20ea713162290b1ef76bb3f999f28f4073d26baf.1553613748.git.vdavydov.dev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20ea713162290b1ef76bb3f999f28f4073d26baf.1553613748.git.vdavydov.dev@gmail.com> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org * Vladimir Davydov [19/03/26 18:56]: > It's equivalent to (itr->search_started && itr->curr_stmt == NULL). OK to push, but same as in the previous patch, I would not use the return value for anything but success/error. We already have a boolean parameter 'equal found', we could turn it into a enum, since 'equal found' and 'eof' are mutually exclusive. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov