From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id C28EF2A79D for ; Thu, 28 Mar 2019 08:02:42 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id H9egdQlEGWOO for ; Thu, 28 Mar 2019 08:02:42 -0400 (EDT) Received: from smtp53.i.mail.ru (smtp53.i.mail.ru [94.100.177.113]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 800402A67C for ; Thu, 28 Mar 2019 08:02:42 -0400 (EDT) Date: Thu, 28 Mar 2019 15:02:39 +0300 From: Kirill Yukhin Subject: [tarantool-patches] Re: [PATCH] sql: set explicit default collation's strength Message-ID: <20190328120239.6gjvrwwzhvkgkitc@tarantool.org> References: <20190326203456.76617-1-ivan.koptelov@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190326203456.76617-1-ivan.koptelov@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: v.shpilevoy@tarantool.org, Ivan Koptelov Hello, On 26 Mar 23:34, Ivan Koptelov wrote: > Before the patch, collations with no strength set used > tertiary strength. But it was not easy to understand it, > because box.space._collation:select{} would return > ... [1, 'unicode', 1, 'ICU', '', {}] ... for such collations. > After the patch default value is set explicitly, so > user would observe : ... [1, 'unicode', 1, 'ICU', '', > {strength='tertiary'}] ... > > Note that box/stat.test.lua is temporary disabled with this > patch. It is done so because the patch is meant for the 2.1.2 > release. Current tarantool version is 2.1.2, so upgrade is done > (using upgrade.lua) and because of it box/stat is broken (it > does not expect changes in upgrade) But after the release would > be made, box/stat would work again, because no changing would be > done in upgrade.lua. To resume, after we set tarantool > version to => 2.1.2 box/stat should be enabled again. > > Closes #3573 > > @TarantoolBot document > Title: default collation strength is explicit tertiary now > Before the patch we already have tertiary strength is default > strength for collations, but it was explicit: > [1, 'unicode', 1, 'ICU', '', {}] > After the patch it's just become explicit: > 1, 'unicode', 1, 'ICU', '', {'strength' = 'tertiary'}] > > Also please fix this https://tarantool.io/en/doc/2.1/book/box/data_model/#collations > There is line saying: "unicode collation observes all weights, > from L1 to Ln (identical)" It was not true and now this fact > would just become obvious. > --- > Branch https://github.com/tarantool/tarantool/tree/sudobobo/gh-3573-add-explicit-default-coll-strength > Issue https://github.com/tarantool/tarantool/issues/3573 I've checked your patch into master & 2.1 branch. -- Regards, Kirill Yukhin