From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 27 Mar 2019 15:06:59 +0300 From: Vladimir Davydov Subject: Re: [tarantool-patches] [PATCH v3 5/5] Raise an error if remote transaction produces non-local changes Message-ID: <20190327120659.th4jknglqv6spjyf@esperanza> References: <36c90408b1cf967adf2d8a433e13ef4f8d061e27.1553255718.git.georgy@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <36c90408b1cf967adf2d8a433e13ef4f8d061e27.1553255718.git.georgy@tarantool.org> To: Georgy Kirichenko Cc: tarantool-patches@freelists.org List-ID: On Fri, Mar 22, 2019 at 03:06:10PM +0300, Georgy Kirichenko wrote: > diff --git a/test/replication/on_replace.result b/test/replication/on_replace.result > index 2e95b90ea..a02b90f7e 100644 > --- a/test/replication/on_replace.result > +++ b/test/replication/on_replace.result > @@ -154,20 +154,27 @@ box.space.s1:replace({1, 2, 3, 4}) > --- > - [1, 2, 3, 4] > ... > -while #(box.space.s2:select()) == 0 do fiber.sleep(0.00001) end > +while (box.info.replication[3 - box.info.id].downstream.status ~= 'stopped') do fiber.sleep(0.00001) end Nit: 3 - box.info.id ? Looks confusing. Why not simply use 1? It should point to the master, shouldn't it? Other than that, the patch looks good to me.