From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id A05E829DAA for ; Wed, 27 Mar 2019 07:45:59 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Es_Atdp40fzp for ; Wed, 27 Mar 2019 07:45:59 -0400 (EDT) Received: from smtp36.i.mail.ru (smtp36.i.mail.ru [94.100.177.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 5735D29C65 for ; Wed, 27 Mar 2019 07:45:59 -0400 (EDT) Date: Wed, 27 Mar 2019 14:45:56 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH v3 2/5] Synchronize lua schema update with space cache Message-ID: <20190327114556.GB10430@chai> References: <2c27dc3efab7420737653d3362570136d885dbb4.1553255718.git.georgy@tarantool.org> <20190327100351.gpo2befo6mulqw2k@esperanza> <20190327103229.4mfg6ptmqiz4vdub@esperanza> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190327103229.4mfg6ptmqiz4vdub@esperanza> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: Georgy Kirichenko * Vladimir Davydov [19/03/27 14:22]: > commit 1f736583361f537c8e1fb4ea0df0b92ee8d50c6d > Author: Vladimir Davydov > Date: Tue Sep 19 14:21:59 2017 +0300 > > box: use trigger to push space data to Lua > > Currently, it is done by space_cache_replace/delete which violates > incapsulation. Let's introduce a trigger that is fired after a change in > a space definition is committed and use it to propagate changes to Lua. > Patch by @kostja. Let's call triggers, but call them directly from space_cache_replace(). Please submit a follow up patch. We discussed this with Georgy, but decided it's a bit outside of the scope of the current patch. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov