From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 27 Mar 2019 14:41:47 +0300 From: Vladimir Davydov Subject: Re: [tarantool-patches] [PATCH v3 4/5] Transaction support for applier Message-ID: <20190327114147.fbgo52ykqveq4gz2@esperanza> References: <2d06385bd5d62551ce1132d3d5c937d417ea9e66.1553255718.git.georgy@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2d06385bd5d62551ce1132d3d5c937d417ea9e66.1553255718.git.georgy@tarantool.org> To: Georgy Kirichenko Cc: tarantool-patches@freelists.org List-ID: On Fri, Mar 22, 2019 at 03:06:09PM +0300, Georgy Kirichenko wrote: > Applier fetch incoming rows to form a transaction and then apply it. > Rows are fetched and stored on fiber gc region until last transaction row > with is_commit was fetched. After fetch a multi row transaction is going to be > applied into txn_begin/txn_commit/txn_rolback boundaries. At this time > we could not apply single row transaction in such boundaries because of > ddl which does not support non auto commit transactions. > > Closes: #2798 > Needed for: #980 > --- > src/box/applier.cc | 218 +++++++++++++++++------ > test/replication/transaction.result | 242 ++++++++++++++++++++++++++ > test/replication/transaction.test.lua | 86 +++++++++ > 3 files changed, 491 insertions(+), 55 deletions(-) > create mode 100644 test/replication/transaction.result > create mode 100644 test/replication/transaction.test.lua This patch looks good to me.