From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Return-Path: <gorcunov@gmail.com>
Date: Wed, 27 Mar 2019 13:30:23 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Subject: Re: [PATCH 1/2] lib/core/fiber: Rename stack_direction to
 stack_growsdown
Message-ID: <20190327103023.GK20626@uranus.lan>
References: <20190319193845.31221-1-gorcunov@gmail.com>
 <20190319193845.31221-2-gorcunov@gmail.com>
 <20190327093510.f6jtxo35kwsv7ywg@esperanza>
 <20190327094849.GI20626@uranus.lan>
 <20190327102037.gtdzzpp53v5wl5ps@esperanza>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190327102037.gtdzzpp53v5wl5ps@esperanza>
To: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: tml <tarantool-patches@freelists.org>
List-ID: <tarantool-patches.dev.tarantool.org>

On Wed, Mar 27, 2019 at 01:20:37PM +0300, Vladimir Davydov wrote:
> > 
> > Symmetrical with what? :)
> 
> +1 / -1 you now :)
> 
>   direction < 0
>   direction > 0
> 
> instead of
> 
>   growsdown
>   !growsdown

OK (jfyi: growsup/down is not only mman specifics but intel sdm as well)

> > > I'd refrain from changing this if there's no other reason rather than
> > > personal taste.
> > 
> > It is not personal taste but rather a common naming (mman syscall).
> > Though I don't insist.
> 
> I wouldn't mind if it was committed. Just that I don't really like
> committing minor changes like this so as not to pollute the git history
> without a strong reason. Up to Kirill or Kostja.

OK, lets drop it. This is nop from functionl pov anyway.