From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Return-Path: <gorcunov@gmail.com>
Date: Wed, 27 Mar 2019 12:48:49 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Subject: Re: [PATCH 1/2] lib/core/fiber: Rename stack_direction to
 stack_growsdown
Message-ID: <20190327094849.GI20626@uranus.lan>
References: <20190319193845.31221-1-gorcunov@gmail.com>
 <20190319193845.31221-2-gorcunov@gmail.com>
 <20190327093510.f6jtxo35kwsv7ywg@esperanza>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190327093510.f6jtxo35kwsv7ywg@esperanza>
To: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: tml <tarantool-patches@freelists.org>
List-ID: <tarantool-patches.dev.tarantool.org>

On Wed, Mar 27, 2019 at 12:35:10PM +0300, Vladimir Davydov wrote:
> >  enum {
> >  	/* The minimum allowable fiber stack size in bytes */
> > @@ -808,7 +808,7 @@ fiber_stack_recycle(struct fiber *fiber)
> >  	 * it anyway.
> >  	 */
> >  	void *start, *end;
> > -	if (stack_direction < 0) {
> > +	if (stack_growsdown) {
> 
> TBO I like stack_direction more as it's looks symmetrical, so to say.

Symmetrical with what? :)

> I'd refrain from changing this if there's no other reason rather than
> personal taste.

It is not personal taste but rather a common naming (mman syscall).
Though I don't insist.