From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 25 Mar 2019 12:30:02 +0300 From: Vladimir Davydov Subject: Re: [tarantool-patches] [PATCH 2/4] vinyl: don't abort transactions that modify only local spaces for ro Message-ID: <20190325093002.zpu6d5mlrabfyu7g@esperanza> References: <1860307.laWNLuDzhG@home.lan> <20190325081351.2xmphfv2w6r6wkt7@esperanza> <4105454.y3sHZnr1ha@home.lan> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4105454.y3sHZnr1ha@home.lan> To: =?utf-8?B?0JPQtdC+0YDQs9C40Lkg0JrQuNGA0LjRh9C10L3QutC+?= Cc: tarantool-patches@freelists.org, kostja@tarantool.org List-ID: On Mon, Mar 25, 2019 at 11:58:18AM +0300, Георгий Кириченко wrote: > On Monday, March 25, 2019 11:13:51 AM MSK Vladimir Davydov wrote: > > On Mon, Mar 25, 2019 at 08:27:28AM +0300, Георгий Кириченко wrote: > > > I think it is out of scope of the task. > > > > So what? This was a known issue when the switch_to_ro was introduced. > > Better fix it now than never, especially counting the fact that it's > > a low hanging fruit after patch 1. > So let it be in a separate patch with assigned ticket. Why? It depends on the previous patch. I ask to move a patch out of a series only if there's a great chance to commit it before the rest of the series. Filing a ticket when the patch is ready looks like excessive bureaucracy to me. In fact, it's just a follow-up for #4016.