From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 25 Mar 2019 11:17:43 +0300 From: Vladimir Davydov Subject: Re: [tarantool-patches] [PATCH 3/4] vinyl: abort affected transactions when space is removed from cache Message-ID: <20190325081743.36qnsjaugtxluxcd@esperanza> References: <2959905.mpcgZ1zIq4@home.lan> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2959905.mpcgZ1zIq4@home.lan> To: =?utf-8?B?0JPQtdC+0YDQs9C40Lkg0JrQuNGA0LjRh9C10L3QutC+?= Cc: tarantool-patches@freelists.org, kostja@tarantool.org List-ID: On Mon, Mar 25, 2019 at 08:26:25AM +0300, Георгий Кириченко wrote: > I definitely dislike introducing a new callback, there are already a lot of > dependencies. Also I'm afraid that this could prevent us from the > transactional ddl implementation. I don't see a way to fix this issue without introducing a new callback. And frankly I don't quite understand your concern. If the new callback proves to be useless / harmful for transaction DDL, we will remove it - after all engine API isn't carved in stone. > We have a space vtab and destroy, why shouldn't we use them? Because the space becomes invalid before it gets destroyed - ALTER moves indexes to the new space before writing to WAL.