From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id B496A2AD6E for ; Fri, 22 Mar 2019 11:45:08 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ACGcoi_vB70O for ; Fri, 22 Mar 2019 11:45:08 -0400 (EDT) Received: from smtp16.mail.ru (smtp16.mail.ru [94.100.176.153]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 59B172AD42 for ; Fri, 22 Mar 2019 11:45:08 -0400 (EDT) Date: Fri, 22 Mar 2019 18:45:01 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH v9 2/7] sql: fix error code for SQL errors in execute.c Message-ID: <20190322154501.GD6548@chai> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: v.shpilevoy@tarantool.org * imeevma@tarantool.org [19/03/22 13:57]: > Currently, functions sql_execute() and sql_prepare_and_execute() > set the ER_SQL_EXECUTE code for all errors that occur during the > execution of a SQL command. This is considered incorrect because > some of these errors may have their own error code. > > In addition, all errors that do not have an error code are VDBE > errors due to issue #3965, so it makes sense to set the error > code ER_VDBE_EXECUTE for all errors without an error code. LGTM. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov