From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 23E1A2A896 for ; Thu, 21 Mar 2019 11:41:23 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5SsUU_bKPYzw for ; Thu, 21 Mar 2019 11:41:23 -0400 (EDT) Received: from smtp47.i.mail.ru (smtp47.i.mail.ru [94.100.177.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id C9C182A868 for ; Thu, 21 Mar 2019 11:41:22 -0400 (EDT) Date: Thu, 21 Mar 2019 18:41:20 +0300 From: Kirill Yukhin Subject: [tarantool-patches] Re: [PATCH v1 1/1] box: fix format of tuple produced with frommap() Message-ID: <20190321154120.lq4d6srux22q46f4@tarantool.org> References: <558c48af114ba67b997489ce2a150ffa1b7f5a22.1553088664.git.kshcherbatov@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <558c48af114ba67b997489ce2a150ffa1b7f5a22.1553088664.git.kshcherbatov@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: v.shpilevoy@tarantool.org, Kirill Shcherbatov Hello, On 20 Mar 16:31, Kirill Shcherbatov wrote: > Previously, all tuples created with frommap() used default format > table_format_runtime, and therefore the created data tuples were > not checked for the ability to be inserted into the target space. > > Moreover frommap(...):tomap(...) procedures sequence also did not > work because tomap(..) routine assumes that the tuple has format > with field names. > > Closes #4045 > > Branch: http://github.com/tarantool/tarantool/tree/kshch/gh-4045-frommap-tuple-format-fix > Issue: https://github.com/tarantool/tarantool/issues/4045 I've checked yout patch into master, 2.1 and 1.10 branches. -- Regards, Kirill Yukhin