From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 1FC922A1BE for ; Thu, 21 Mar 2019 10:00:05 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8yUhugzrwsyf for ; Thu, 21 Mar 2019 10:00:05 -0400 (EDT) Received: from smtp16.mail.ru (smtp16.mail.ru [94.100.176.153]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 4FBA42A17F for ; Thu, 21 Mar 2019 10:00:04 -0400 (EDT) Date: Thu, 21 Mar 2019 17:00:01 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH 1/2] sql: make type in column-meta be consistent with NoSQL names Message-ID: <20190321140001.GF2574@chai> References: <2bb818aa4a68f456c5460cdaa3a519bd1bb57e2f.1552327461.git.korablev@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2bb818aa4a68f456c5460cdaa3a519bd1bb57e2f.1552327461.git.korablev@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: v.shpilevoy@tarantool.org, Nikita Pettik * Nikita Pettik [19/03/11 21:10]: > Column meta-information which is sent alongside execution result via > IProto protocol, contains string representation of column type. > In some cases, name of type is different from actual type of field. For > instance, if column has type SCALAR, string representation in > meta-information will be "BLOB"; for NUMBER NoSQL type - it will be > "NUMERIC"; for STRING - "TEXT". Instead of this mess, let's always return > exact name of underlying NoSQL type. I'm ok with this patch. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov