From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id EBFF62625B for ; Wed, 20 Mar 2019 11:40:04 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wDJ-_ZExImsa for ; Wed, 20 Mar 2019 11:40:04 -0400 (EDT) Received: from smtp46.i.mail.ru (smtp46.i.mail.ru [94.100.177.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 8922B245C4 for ; Wed, 20 Mar 2019 11:40:04 -0400 (EDT) Date: Wed, 20 Mar 2019 18:40:02 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH] Raise an error if remote transaction produces non-local changes Message-ID: <20190320154002.GE6612@chai> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: Georgy Kirichenko * Georgy Kirichenko [19/03/20 13:23]: > + if (txn->n_remote_rows > 0 && stmt->row->replica_id == 0 && > + stmt->space->def->opts.group_id != GROUP_LOCAL) { > + diag_set(ClientError, ER_UNSUPPORTED, > + "transaction", "mixing local and remote changes"); > + goto fail; > + } Would it be possible to move this check to the applier so that it does not affect the main scenario? -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov