From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 578AA2A4D5 for ; Wed, 20 Mar 2019 06:29:27 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CTh5B19TH23M for ; Wed, 20 Mar 2019 06:29:27 -0400 (EDT) Received: from smtp20.mail.ru (smtp20.mail.ru [94.100.179.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 0ED3C2A4D2 for ; Wed, 20 Mar 2019 06:29:26 -0400 (EDT) Date: Wed, 20 Mar 2019 13:29:23 +0300 From: Kirill Yukhin Subject: [tarantool-patches] Re: [PATCH] sql: fix recovery of VIEW space Message-ID: <20190320102923.yoirguzvnpx6jnxn@tarantool.org> References: <20190319172103.92279-1-korablev@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190319172103.92279-1-korablev@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: kostja@tarantool.org, Nikita Pettik Hello, On 19 Mar 20:21, Nikita Pettik wrote: > During creation of VIEW space, string containing its definition (i.e. > "SELECT ...") is parsed to fetch names of referenced spaces. By those > names real struct space objects are found using schema_find_id(). > This function processes lookup in _space using its secondary index. > On the other hand, secondary indexes of _space are unavailable during > this stage of recovery, so this lookup fails and whole recovery process > aborts. > > It is worth mentioning that now we can fetch space directly from > in-memory cache using its name (originally, when view reference counter > was introduced, we couldn't do this due to absence of name-cache). So, > to fix this issue, let's use space_by_name() instead of schema_find_id() > > Closes #3814 > --- > Branch: https://github.com/tarantool/tarantool/tree/np/gh-3814-view-update-references-recovery > Issue: https://github.com/tarantool/tarantool/issues/3814 Patch is OK. I've cheked it into 2.1 branch. -- Regards, Kirill Yukhin