From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Date: Tue, 19 Mar 2019 18:43:24 +0300 From: Konstantin Osipov Subject: Re: [tarantool-patches] [PATCH v2 1/5] lib: introduce json_path_is_multikey helper Message-ID: <20190319154324.GE32279@chai> References: <2ea5cf6ff29e786687e4ddd6110a1cc4ecc6d0a3.1552998554.git.kshcherbatov@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2ea5cf6ff29e786687e4ddd6110a1cc4ecc6d0a3.1552998554.git.kshcherbatov@tarantool.org> To: tarantool-patches@freelists.org Cc: vdavydov.dev@gmail.com, Kirill Shcherbatov List-ID: * Kirill Shcherbatov [19/03/19 16:15]: > Introduced a new json_path_is_multikey routine to test if > JSON path contains array index placeholder JSON_TOKEN_ANY and > return multikey_path_len if so. > + ok 9 - test json_path_is_multikey: non-multikey path > + ok 10 - test json_path_is_multikey: multikey path > + ok 11 - test json_path_is_multikey: multikey path 8/8 This coverage is insufficient. You should at least test an empty path, a path with * in the beginning, middle and end. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov