From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id E6E7529295
	for <tarantool-patches@freelists.org>; Tue, 19 Mar 2019 07:39:52 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 1hjGJ-ISELzG for <tarantool-patches@freelists.org>;
	Tue, 19 Mar 2019 07:39:52 -0400 (EDT)
Received: from smtp51.i.mail.ru (smtp51.i.mail.ru [94.100.177.111])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 9E25529138
	for <tarantool-patches@freelists.org>; Tue, 19 Mar 2019 07:39:52 -0400 (EDT)
Date: Tue, 19 Mar 2019 14:39:49 +0300
From: Kirill Yukhin <kyukhin@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH] lua: remove digest.sha() and digest.sha_hex()
Message-ID: <20190319113948.ftr7iqa2frw33whm@tarantool.org>
References: <6c81abf4ab1cca5f599153553a1b28f3fac89115.1552949246.git.alexander.turenko@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <6c81abf4ab1cca5f599153553a1b28f3fac89115.1552949246.git.alexander.turenko@tarantool.org>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-Help: <mailto:ecartis@freelists.org?Subject=help>
List-Unsubscribe: <mailto:tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-Subscribe: <mailto:tarantool-patches-request@freelists.org?Subject=subscribe>
List-Owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-Archive: <http://www.freelists.org/archives/tarantool-patches>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: tarantool-patches@freelists.org

Hello,

On 19 Mar 01:49, Alexander Turenko wrote:
> SHA-0 is considered weak for years and was removed in OpenSSL since
> 1.1.0.
> 
> These Lua functions did not work since 15ed10e4, but give 'Digest
> method "sha" is not supported' error for any input. Removed them to
> don't confuse a user with a Tab completion.
> 
> Follow up #1722.
> Fixes #4028.
> ---
> 
> issue: https://github.com/tarantool/tarantool/issues/4028
> branch: https://github.com/tarantool/tarantool/tree/Totktonada/gh-4028-remove-digest-sha-0

I've checked your patch into 2.1 branch.

--
Regards, Kirill Yukhin