From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 19 Mar 2019 00:19:19 +0300 From: Konstantin Osipov Subject: Re: [tarantool-patches] Re: [PATCH] lib/core/fiber: Initialize stack_watermark where appropriate Message-ID: <20190318211919.GB13557@chai> References: <20190318172352.14128-1-gorcunov@gmail.com> <20190318175246.22utl4hoc3jnxuk2@esperanza> <20190318185529.GA11507@chai> <20190318190446.GD2469@uranus.lan> <20190318191008.GA13557@chai> <20190318191746.GE2469@uranus.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190318191746.GE2469@uranus.lan> To: tarantool-patches@freelists.org Cc: vdavydov.dev@gmail.com List-ID: * Cyrill Gorcunov [19/03/18 22:20]: > On Mon, Mar 18, 2019 at 10:10:08PM +0300, Konstantin Osipov wrote: > > > > > > Even 8 elements are not guarantee us from false positives and > > > with a sole element the situation would be even worse. > > > > Well, then let's increase the number of elements to 32 or 64, or, > > better yet, 128, to make the situation better. > > > > Why did you guys choose 8? > > To cover low 1024 bytes. Maximal path is about 4K limit > so I think in average ~1/4 of page should catch paths > on stack. Okay, well, that at least a plausible cause, I guess I'd be nice to see it in the comment for the poison array. However, you could use 4 integers and a larger poison offset?-)) -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov